Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(popover): ensure popover doesn't reopen when trigger is clicked and autoClose is true #10948

Merged
merged 2 commits into from
Dec 3, 2024
Merged

test(popover): ensure popover doesn't reopen when trigger is clicked and autoClose is true #10948

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
386dbd9
test(popover): ensure popover doesn't reopen when trigger is clicked …
Elijbet Dec 3, 2024
c6b87d9
add auto-close
Elijbet Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions packages/calcite-components/src/components/popover/popover.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,6 +683,31 @@ describe("calcite-popover", () => {
expect(await popover.getProperty("open")).toBe(false);
});

it("should not reopen when trigger is clicked and autoClose=true", async () => {
const page = await newE2EPage();

await page.setContent(html`
<calcite-popover auto-close reference-element="ref">Content</calcite-popover>
<button id="ref">Button</button>
`);

await page.waitForChanges();
const popover = await page.find("calcite-popover");

expect(await popover.getProperty("open")).toBe(false);

const referenceElement = await page.find("#ref");
await referenceElement.click();
await page.waitForChanges();

expect(await popover.getProperty("open")).toBe(true);

await referenceElement.click();
await page.waitForChanges();

expect(await popover.getProperty("open")).toBe(false);
});

describe("setFocus", () => {
const createPopoverHTML = (contentHTML?: string, attrs?: string) =>
`<calcite-popover open ${attrs} reference-element="ref">${contentHTML}</calcite-popover><button id="ref">Button</button>`;
Expand Down
Loading