refactor(tree-item): limit padding-y CSS var to top/bottom spacing, remove end indentation #3237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
refactor
jcfranco
reviewed
Nov 1, 2021
| @@ -174,4 +174,26 @@ describe("calcite-tree-item", () => { | |||
| ancestors.forEach(async (node) => expect(await node.getProperty("indeterminate")).toBe(true)); | |||
| }); | |||
| }); | |||
|
|
|||
| describe("CSS Custom Properties for style overrides", () => { | |||
There was a problem hiding this comment.
This is great. I think we could add a test util for this (outside of this PR). Ideally a spec test since we don't need interaction.
There was a problem hiding this comment.
Thanks! For now I'll remove this test since we're not exposing the var for style overrides.
jcfranco
approved these changes
Nov 1, 2021
There was a problem hiding this comment.
Code LGTM!
I'll defer to @macandcheese on adding --calcite-tree-padding-y.
|
Should this css variable be internal? I don't see a reason for it to be public. |
…f github.com:Esri/calcite-components into caripizza/3223-tree-item-limit-padding-y-var-spacing
|
@jcfranco can you please approve Screener changes on this one? |
jcfranco
deleted the
caripizza/3223-tree-item-limit-padding-y-var-spacing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #3223
Summary
Refactors calcite-tree-item styles to only apply the
--calcite-tree-padding-yCSS var to top/bottom spacing.Also adds the following stylesheet changes: