feat(tree): add none selection mode #5128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
|
@macandcheese Could you test the latest tweaks? 🙇 |
driskull
approved these changes
Aug 16, 2022
| @@ -177,7 +183,7 @@ | |||
| } | |||
|
|
|||
| // dropdown expanded and not selected | |||
| :host([has-children][expanded]:not([selected])) > .node-container { | |||
| :host([has-children][expanded]:not([selected]):not([selection-mode="none"])) > .node-container { | |||
There was a problem hiding this comment.
nitpick: some of these selectors are getting pretty complex. Maybe at some point we move this logic to the tsx file?
There was a problem hiding this comment.
Yeah, I went with the simplest option for now. I think we'll have to do a pass on complex selectors and see which ones are better off as dynamic classes vs. their styling equivalent. cc @benelan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #3121
Summary
This introduces a new
noneselection mode that will still allow tree navigation, but prevent an item from being selected. ThecalciteTreeSelectevent will emit as well after an item is 'selected'.