chore(demo-theme): themed demo helper #9645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
alisonailea
removed
the
Stale
jcfranco
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Awesome!
Approving to get this in for today's testing, but I do have some notes:
- Can we add doc to the theme helper with setup examples?
- Are the updates to the button page temporary or something that we'd like to promote across all component pages? We could also consider adding a specific theme demo page.
- Can we add a note on current limitations of the helper? IIRC, stateful CSS props are not supported.
driskull
approved these changes
Jul 8, 2024
| shadowColor: "black", | ||
| shadowValues: "0 1px 2px 0 1", | ||
| space: "24px", | ||
| text: "green", |
There was a problem hiding this comment.
should this maybe be textColor?
Added
Not intended to be temporary. The idea was to allow these demos to be added to any page although long-term it might be good to have a specific theme demo page with all/many components.
There aren't any limitations as far as I know. Stateful CSS props are supported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9644
Summary
themed demo helper