test(loader): add component token E2E tests #9726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
alisonailea
requested changes
Jul 17, 2024
There was a problem hiding this comment.
I think this one may have been done already. Can you resolve conflicts with the epic?
- I think we want to leave the variables that were already made available becuase they were probably requested to fit a user use case. We just need to make sure they align with our naming schema.
- -size is preferred to -width
- -space is preferred to -padding
- Skye asked that we reduce loader to a single color variable
| * @prop --calcite-loader-text-color: var(--calcite-color-text-1); defines the text color of a loader. | ||
| * @prop --calcite-loader-track-color-determinate: var(--calcite-color-border-3); defines the track color of a "determinate" loader | ||
| * @prop --calcite-loader-text-color: defines the text color of a loader. | ||
| * @prop --calcite-loader-track-color-determinate: defines the track color of a "determinate" loader |
There was a problem hiding this comment.
I think this should be simplified to --calcite-loader-track-color
github-actions
bot
removed
the
Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7190
Summary
✨🧪✨