-
Notifications
You must be signed in to change notification settings - Fork 76
testing conventions
Components should have an automated test for any incoming features or bug fixes. Make sure all tests pass as PRs will not be allowed to merge if there is a single test failure.
We encourage writing expressive test cases and code that indicates intent. Use comments sparingly when the aforementioned can't be fully achieved. Keep it clean!
Please see Stencil's doc for more info on end-to-end testing. See one of our test examples here.
In most cases, when working with components, you will need to write end-to-end tests.
If you are adding or updating shared utilities or shared modules you should make sure that there are unit tests covering those use cases.
You don't have to worry about writing visual regression tests. We cover those automatically using Chromatic in our build pipeline.
There are helpers and utilities to make testing common workflows easier. commonTests.ts
contains common tests that you can import and use for your component. For example, every component should have an accessible
test. To use the test in your component, import the helper and assert that the component is accessible.
import { accessible } from "../../tests/commonTests";
it("is accessible", async () =>
accessible(`<calcite-example>${content}</calcite-example>`));
Here is an example of the helper test usage in accordion.e2e.ts
.
There are many more useful, common tests that you should use in specific scenarios. In most IDEs or text editors, you can search the function name of a common test to find usage examples in component's end-to-end test files.
In addition to the common tests, there are also test utilities in utils.ts
. These utilities are created to avoid duplicate code in component end-to-end test files. If you find yourself creating the same test function for different components, then it should be moved to utils.ts
. A good example is getElementXY
. Determining the screen location of an element can be very important when testing interactive components. Here are some end-to-end tests where the utility is used in color-picker.e2e.ts
, input-e2e.ts
, shell-panel.e2e.ts
, and slider.e2e.ts
.
This is only necessary if a component's test will produce a lot of console messages in a test run.
As a best practice when writing tests, prevent emitting console warnings by stubbing them. Depending on the tested component, this may also apply to other console APIs.
Console warnings can end up polluting the build output messaging that makes it more difficult to identify real issues. By stubbing console.warn
, you can prevent warning messages from displaying in the build. See color.e2e
for an example.
If you notice that a test fails intermittently during local or CI test runs, it is unstable and must be skipped to avoid holding up test runs, builds and deployments.
To skip a test, use the skip
method that's available on tests, or suites and submit a pull request. Once that's done, please create a follow-up issue by choosing the unstable test template and filling it out.