Merge branch 'master' into 11994/summary-validation-error

Esri · Dec 2, 2024 · 341173e · 341173e
2 parents c129489 + 0329f51
commit 341173e
Show file tree

Hide file tree

Showing 8 changed files with 44 additions and 30 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/common/CHANGELOG.md b/packages/common/CHANGELOG.md
@@ -1,3 +1,10 @@
+## @esri/hub-common [15.13.1](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2024-11-27)
+
+
+### Bug Fixes
+
+* **hub-common:** fix Events 3 create and edit form validations ([#1749](https://github.com/Esri/hub.js/issues/1749)) ([5a20b99](https://github.com/Esri/hub.js/commit/5a20b999ec88248c0beb16aed7ac4de365d14191))
+
 # @esri/hub-common [15.13.0](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2024-11-25)
 
 

diff --git a/packages/common/package-lock.json b/packages/common/package-lock.json
diff --git a/packages/common/package.json b/packages/common/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@esri/hub-common",
-  "version": "15.13.0",
+  "version": "15.13.1",
   "description": "Common TypeScript types and utility functions for @esri/hub.js.",
   "main": "dist/node/index.js",
   "module": "dist/esm/index.js",

diff --git a/packages/common/src/events/_internal/EventSchemaCreate.ts b/packages/common/src/events/_internal/EventSchemaCreate.ts
@@ -21,6 +21,7 @@ export const EventEditorTypes = [
 export const buildSchema = (): IConfigurationSchema => {
   const { startDate } = getDefaultEventDatesAndTimes();
   return {
+    $async: true,
     required: ["name", "startDate", "endDate"],
     properties: {
       name: ENTITY_NAME_SCHEMA,

diff --git a/packages/common/src/events/_internal/EventSchemaEdit.ts b/packages/common/src/events/_internal/EventSchemaEdit.ts
@@ -20,6 +20,7 @@ import {
  */
 export const buildSchema = (): IConfigurationSchema => {
   return {
+    $async: true,
     required: ["name", "startDate", "endDate", "timeZone"],
     properties: {
       name: ENTITY_NAME_SCHEMA,

diff --git a/packages/common/test/events/_internal/EventSchemaCreate.test.ts b/packages/common/test/events/_internal/EventSchemaCreate.test.ts
@@ -27,6 +27,7 @@ describe("EventSchemaCreate", () => {
       const res = buildSchema();
       expect(getDefaultEventDatesAndTimesSpy).toHaveBeenCalledTimes(1);
       expect(res).toEqual({
+        $async: true,
         required: ["name", "startDate", "endDate"],
         properties: {
           name: ENTITY_NAME_SCHEMA,

diff --git a/packages/common/test/events/_internal/EventSchemaEdit.test.ts b/packages/common/test/events/_internal/EventSchemaEdit.test.ts
@@ -21,17 +21,9 @@ import {
 describe("EventSchemaEdit", () => {
   describe("buildSchema", () => {
     it("should return the expected ui schema", async () => {
-      const datesAndTimes = {
-        startDate: "2024-03-31",
-        startDateTime: new Date(),
-        startTime: "12:00:00",
-        endDate: "2024-03-31",
-        endDateTime: new Date(),
-        endTime: "14:00:00",
-        timeZone: "America/New_York",
-      };
       const res = buildSchema();
       expect(res).toEqual({
+        $async: true,
         required: ["name", "startDate", "endDate", "timeZone"],
         properties: {
           name: ENTITY_NAME_SCHEMA,