Revert "fix(hub-common): handle undefined context.portal (#1245)" (#1247

)

This reverts commit 3ae3795.

.github/workflows/release.yml

@@ -9,7 +9,6 @@ on:
       - beta
       # - alpha disabled to allow push to alpha then merge to master w/o incurring a release
       - next
-      - '[0-9]+.[0-9]+.x'
     # Dont run if it's just markdown or doc files
     paths-ignore:
       - "**.md"

package.json

@@ -199,7 +199,6 @@
 	},
 	"release": {
 		"branches": [
-			"+([1-9])?(.{+([1-9]),x}).x",
 			"master",
 			{
 				"name": "next",

packages/common/src/sites/HubSite.ts

@@ -142,7 +142,7 @@ export class HubSite
   ): IHubSite {
     // ensure we have the orgUrlKey
     if (!partialSite.orgUrlKey) {
-      partialSite.orgUrlKey = context.portal?.urlKey;
+      partialSite.orgUrlKey = context.portal.urlKey;
     }
     // extend the partial over the defaults
     const pojo = { ...DEFAULT_SITE, ...partialSite } as IHubSite;

packages/common/test/sites/HubSite.test.ts

@@ -52,10 +52,7 @@ describe("HubSite Class:", () => {
   describe("static methods:", () => {
     it("loads from minimal json", () => {
       const createSpy = spyOn(HubSitesModule, "createSite");
-      const chk = HubSite.fromJson(
-        { name: "Test Site" },
-        unauthdCtxMgr.context
-      );
+      const chk = HubSite.fromJson({ name: "Test Site" }, authdCtxMgr.context);
 
       expect(createSpy).not.toHaveBeenCalled();
       expect(chk.toJson().name).toEqual("Test Site");