refactor: revert some schema enums

affects: @esri/hub-common
Esri · Dec 2, 2024 · f953c2c · f953c2c
1 parent 09a7eb3
commit f953c2c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 46 deletions.
diff --git a/packages/common/src/core/schemas/shared/CatalogSchema.ts b/packages/common/src/core/schemas/shared/CatalogSchema.ts
@@ -1,11 +1,6 @@
 import { EntityType, targetEntities } from "../../../search/types/IHubCatalog";
 import { IConfigurationSchema } from "../types";
-import {
-  CARD_TITLE_TAGS,
-  CORNERS,
-  DROP_SHADOWS,
-  SHOW_THUMBNAIL,
-} from "./enums";
+import { CARD_TITLE_TAGS, CORNERS, DROP_SHADOWS } from "./enums";
 
 /** JSON schema for an IPredicate */
 export const PredicateSchema: IConfigurationSchema = {
@@ -100,8 +95,8 @@ export const GalleryDisplayConfigSchema: IConfigurationSchema = {
     },
     showThumbnail: {
       type: "string",
-      enum: Object.keys(SHOW_THUMBNAIL),
-      default: SHOW_THUMBNAIL.show,
+      enum: ["show", "hide", "grid"],
+      default: "show",
     },
     corners: {
       type: "string",

diff --git a/packages/common/src/core/schemas/shared/enums.ts b/packages/common/src/core/schemas/shared/enums.ts
@@ -40,35 +40,3 @@ export enum CARD_TITLE_TAGS {
   h5 = "h5",
   h6 = "h6",
 }
-
-/**
- * Show thumbnail options,
- * show | hide | only show in grid layout
- */
-export enum SHOW_THUMBNAIL {
-  show = "show",
-  hide = "hide",
-  grid = "grid",
-}
-
-/**
- * Layouts for gallery
- */
-export enum LAYOUTS {
-  list = "list",
-  grid = "grid",
-  table = "table",
-  map = "map",
-  compact = "compact",
-  calendar = "calendar",
-}
-
-/**
- * Button styles
- */
-export enum BUTTON_STYLES {
-  outline = "outline",
-  solid = "solid",
-  outlineFilled = "outline-filled",
-  transparent = "transparent",
-}
diff --git a/packages/common/src/search/types/IHubCatalog.ts b/packages/common/src/search/types/IHubCatalog.ts
@@ -1,10 +1,7 @@
-import { LAYOUTS } from "../../core/schemas/internal/metrics/interfaces";
 import {
-  BUTTON_STYLES,
   CARD_TITLE_TAGS,
   CORNERS,
   DROP_SHADOWS,
-  SHOW_THUMBNAIL,
 } from "../../core/schemas/shared/enums";
 import { WellKnownCollection } from "../wellKnownCatalog";
 
@@ -198,12 +195,12 @@ export interface IGalleryDisplayConfig {
    * If this is true on a collection's display config, that collection will not be shown in the gallery.
    */
   hidden?: boolean;
-  layout?: LAYOUTS;
+  layout?: "list" | "grid" | "map" | "table" | "calendar" | "compact";
   cardTitleTag?: CARD_TITLE_TAGS;
-  showThumbnail?: SHOW_THUMBNAIL;
+  showThumbnail?: "show" | "hide" | "grid";
   corners?: CORNERS;
   shadow?: DROP_SHADOWS;
   showLinkButton?: boolean;
-  linkButtonStyle?: BUTTON_STYLES;
+  linkButtonStyle?: "solid" | "outline" | "outline-fill" | "transparent";
   linkButtonText?: string;
 }