fix: checkPermission tolerates context without userHubSettings (#1416)

Esri · Feb 16, 2024 · f9e7669 · f9e7669
1 parent 128a1d2
commit f9e7669
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/common/src/permissions/checkPermission.ts b/packages/common/src/permissions/checkPermission.ts
@@ -108,7 +108,7 @@ export function checkPermission(
 
   // We also check the context.userHubSettings.preview array
   // which can also be used to enable features.
-  if (context.userHubSettings.preview) {
+  if (context.userHubSettings?.preview) {
     const preview = getWithDefault(
       context,
       "userHubSettings.preview",

diff --git a/packages/common/test/permissions/checkPermission.test.ts b/packages/common/test/permissions/checkPermission.test.ts
@@ -418,5 +418,11 @@ describe("checkPermission:", () => {
 
       expect(chk.access).toBe(true);
     });
+    it("tolerates context without userHubSettings", () => {
+      const localCtx = cloneObject(premiumCtxMgr.context);
+      delete localCtx.userHubSettings;
+      const chk = checkPermission("hub:feature:workspace", localCtx);
+      expect(chk.access).toBe(false);
+    });
   });
 });