fix: reverting changes for uniform product #1159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1159 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 730 737 +7
Lines 12875 13006 +131
Branches 2178 2198 +20
==========================================
+ Hits 12875 13006 +131
|
* feat: add parents to permissions, deprecations for Capabilities * feat: add IEntityFeatures and configure for Projects * refactor: address PR feedback, implement service checks * feat: add protected to entity and property map * feat: add default features to all appropriate entities * refactor: address PR feedback
# @esri/hub-common [13.38.0](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2023-08-15) ### Bug Fixes * export ihubgroup ([#1160](#1160)) ([0d29518](0d29518)) ### Features * permission parents, deprecations for Capabilities ([#1158](#1158)) ([83659b1](83659b1))
## @esri/hub-common [13.38.1](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2023-08-16) ### Bug Fixes * remove additionalInfo from userResultToCardModel ([#1162](#1162)) ([c4c72c8](c4c72c8))
…o b/7208-revert-to-uniform
|
There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting getLocationOptions changes to be uniform with other workspace entities.
@tomwayson Should I fully remove commented code? Or is it fine leaving it in for future tickets?
@thomas-hervey Content now saves correctly and three options display.
Closes Issues: #7208
Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide
used semantic commit messages
PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)
updated
peerDependenciesas needed. CRITICAL our automated release system can not be counted on to updatepeerDependenciesso we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.