Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(hub-discussions): update Discussions Guide documentation #1739

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

velveetachef
Copy link
Contributor

affects: @esri/hub-common

  1. Description: Update developer documentation for the Discussions guide

  2. Instructions for testing:

  3. Closes Issues: # (if appropriate)

  4. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  5. used semantic commit messages

  6. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  7. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

Copy link
Contributor

@ethanspiro ethanspiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great doc updates, thanks!

Copy link

There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label.

@github-actions github-actions bot added the Stale Stale issue - update or it will be closed label Nov 25, 2024
affects: @esri/hub-common, @esri/hub-discussions
@velveetachef velveetachef removed the Stale Stale issue - update or it will be closed label Nov 25, 2024
@ethanspiro ethanspiro self-requested a review November 25, 2024 22:34
@velveetachef velveetachef merged commit e1f3768 into v2-discussions-release Nov 25, 2024
5 checks passed
@velveetachef velveetachef deleted the f/5523-v2-discussions-docs branch November 25, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants