Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hub-discussions): remove files/fns that were duplicated between h… #1743

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

rweber-esri
Copy link
Contributor

@rweber-esri rweber-esri commented Nov 19, 2024

…ub-discussions and hub-common p

affects: @esri/hub-discussions

ISSUES CLOSED: 11042

  1. Description:
  • Removes files & fns that were duplicated in both hub-discussions and hub-common from the hub-discussions package
  • Updates fns to use the discussionsApiRequest fn from hub-common rather than the duplicate in hub-discussions that was removed
  1. Instructions for testing:

  2. Closes Issues: #11042

  3. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  4. used semantic commit messages

  5. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  6. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

I will update peer-dependencies as a separate commit on this branch once is merged and the new version is published.

Copy link
Contributor

@juliannaeapicella juliannaeapicella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from f/discussion-posts-as-csv-1 to master November 19, 2024 20:31
…ub-discussions and hub-common p

affects: @esri/hub-discussions

ISSUES CLOSED: 11042
…mmon to 15.7.1

affects: @esri/hub-discussions

ISSUES CLOSED: 11042
ISSUES CLOSED: 11042
@rweber-esri rweber-esri merged commit 04a7067 into master Nov 19, 2024
5 checks passed
@rweber-esri rweber-esri deleted the f/discussion-posts-as-csv-2 branch November 19, 2024 21:19
esri-dcdev-2 pushed a commit that referenced this pull request Nov 19, 2024
## @esri/hub-discussions [29.2.1](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2024-11-19)

### Bug Fixes

* **hub-discussions:** remove files/fns that were duplicated between h… ([#1743](#1743)) ([04a7067](04a7067))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants