Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hub-discussions): add exportPosts fn to export discussion posts as CSV string #1745

Conversation

rweber-esri
Copy link
Contributor

@rweber-esri rweber-esri commented Nov 20, 2024

  1. Description:
  • Adds exportPosts fn to export discussion posts as CSV string
  • Adds tests for new exportPosts fn
  1. Instructions for testing:

  2. Closes Issues: # (if appropriate)

  3. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  4. used semantic commit messages

  5. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  6. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

Peer dependencies for hub-common will need to be updated on this branch after PR-1744 merges/publishes

@rweber-esri rweber-esri changed the base branch from master to f/add-exportPosts-fn-to-export-discussion-posts-as-csv-string November 20, 2024 15:17
Copy link
Contributor

@juliannaeapicella juliannaeapicella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from f/add-exportPosts-fn-to-export-discussion-posts-as-csv-string to master November 20, 2024 15:20
…as CSV string

affects: @esri/hub-discussions

ISSUES CLOSED: 11042
affects: @esri/hub-discussions

ISSUES CLOSED: 11042
@rweber-esri rweber-esri force-pushed the f/add-exportPosts-fn-to-export-discussion-posts-as-csv-string-2 branch from 5143596 to 8128031 Compare November 20, 2024 15:58
@rweber-esri rweber-esri merged commit 5dba4b4 into master Nov 22, 2024
5 checks passed
@rweber-esri rweber-esri deleted the f/add-exportPosts-fn-to-export-discussion-posts-as-csv-string-2 branch November 22, 2024 14:22
esri-dcdev-2 pushed a commit that referenced this pull request Nov 22, 2024
# @esri/hub-discussions [29.3.0](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2024-11-22)

### Features

* **hub-discussions:** add exportPosts fn to export discussion posts as CSV string ([#1745](#1745)) ([5dba4b4](5dba4b4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants