Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hub-common): event implements image picker #1784

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

juliannaeapicella
Copy link
Contributor

  1. Description: Event entities implement URL image picker.

  2. Instructions for testing:

  3. Closes Issues: #12182

  4. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  5. used semantic commit messages

  6. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  7. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

@juliannaeapicella juliannaeapicella added the Draft Draft PR or Issue (don't mark stale) label Jan 27, 2025
Copy link
Contributor

@rweber-esri rweber-esri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a couple minor comments for consideration

packages/common/src/events/HubEvent.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Draft Draft PR or Issue (don't mark stale)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants