Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hub-common): update spatial element from default dcat us template #1788

Merged
merged 5 commits into from
Jan 31, 2025

Conversation

sansth1010
Copy link
Contributor

@sansth1010 sansth1010 commented Jan 30, 2025

  1. Description: This PR updates spatial field of default DCAT US feed template to use default transformer computeSpatialProperty with extent value. computeSpatialProperty computes valid value from extent so should be used with extent by default.

  2. Instructions for testing:

  3. Closes Issues: #12271

  4. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  5. used semantic commit messages

  6. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  7. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

@sansth1010 sansth1010 changed the title fix(hub-common): remove spatial element from default dcat us template fix(hub-common): update spatial element from default dcat us template Jan 30, 2025
@sansth1010 sansth1010 self-assigned this Jan 30, 2025
Copy link
Contributor

@sonofflynn89 sonofflynn89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work San! Thank you!

@sansth1010 sansth1010 merged commit 064deea into master Jan 31, 2025
5 checks passed
@sansth1010 sansth1010 deleted the b/12271-fix-dcat-us-default-template branch January 31, 2025 00:13
esri-dcdev-2 pushed a commit that referenced this pull request Jan 31, 2025
## @esri/hub-common [15.25.1](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2025-01-31)

### Bug Fixes

* **hub-common:** update spatial element from default dcat us template ([#1788](#1788)) ([064deea](064deea))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants