Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DONE] Bugfix import video and thumbnail #1253

Merged
merged 5 commits into from
Jan 24, 2025
Merged

[DONE] Bugfix import video and thumbnail #1253

merged 5 commits into from
Jan 24, 2025

Conversation

LoicBonavent
Copy link
Collaborator

Bugfix

Modifications to the video import module:

  • Replace pytube by pytubefix library, and generate PO token (see https://pytubefix.readthedocs.io/en/latest/user/po_token.html)
  • Manage the lack of URL field in some Peertube videos
    Modifications to the video module:
  • Handle exception to avoid sending an error email, for get_thumbnail function (typically when the generated thumbnail presents a problem)

@Badatos Badatos self-requested a review January 22, 2025 15:04
Badatos
Badatos approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@Badatos Badatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour ces corrections !
Juste une petite remarque.

pod/import_video/views.py Outdated

# To convert old BBB presentation
from pod.main.tasks import task_start_bbb_presentation_encode_and_upload_to_pod
from pod.main.tasks import task_start_bbb_presentation_encode_and_move_to_destination

DEBUG = getattr(settings, "DEBUG", True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si DEBUG n'est pas utilisé ici autant supprimer cette ligne ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah oui, c'était lors de mes tests. Je viens de l'enlever

@Badatos Badatos added the bug Something isn't working label Jan 23, 2025
@Badatos Badatos merged commit 2bb32d7 into EsupPortail:develop Jan 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Badatos Badatos Badatos approved these changes

@cbissler cbissler cbissler approved these changes

Assignees

@LoicBonavent LoicBonavent

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LoicBonavent @cbissler @Badatos