Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip border functionality #46

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

SerodioJ
Copy link

@SerodioJ SerodioJ commented Apr 1, 2024

  • adapt GLCM class to compute GLCM with information only from the selected window, without neighboring information that is only present on the window pair, by skipping the border.

The image below exemplifies the process for each direction
glcm_window

Note that the default behavior is the same as it was previously (skip_border = False).

@SerodioJ
Copy link
Author

SerodioJ commented Apr 1, 2024

  • update tests

@SerodioJ
Copy link
Author

SerodioJ commented Apr 1, 2024

Hi @Eve-ning,
I modified the GLCM class a bit so that the results would match when computing the same features with scikit-image (skimage.feature.graycomatrix followed by skimage.feature.graycoprops )

I also intend to add some features, but I will leave it to a different PR

  • Entropy: $\sum_{i,j=0}^{N-1} {P_{i,j}(-lnP_{i,j}})$
  • Energy: $\sqrt{ASM}$
  • Standard Deviation: $\sqrt{Variance}$

The last two are just the square root of already implemented features.

@Eve-ning
Copy link
Owner

Eve-ning commented Apr 9, 2024

Hi @SerodioJ, thanks for your contribution, I'll likely only be able to get to reviewing this next month!

@SerodioJ
Copy link
Author

Hi @Eve-ning. Will you be able to review this PR this month?

@Eve-ning
Copy link
Owner

Hi @Eve-ning. Will you be able to review this PR this month?

I'll try to, I can't promise this as I've many other obligations. Your team can opt to pip install from your GitHub branch if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants