Fixed serverless permissions

serverless.yml

@@ -11,24 +11,59 @@ provider:
     # MONGODB_URI: ${ssm:/accounts-service/MONGODB_URI}
     # EVENT_BUS_NAME: ${ssm:/my-service/EVENT_BUS_NAME~true}
 
+
 functions:
   transactionEventListener:
-    handler: dist/handlers/transactionEventListener.handler
+    handler: src/handlers/transactionEventListener.handler
     events:
       - eventBridge:
           eventBus: default
           pattern:
             source:
-              - accounts-service
+              - 'accounts-service'
             detail-type:
-              - TransactionCreated
+              - 'TransactionCreated'
+          # retryPolicy:
+          #   maximumRetryAttempts: 5
 
   getMonthlyStatements:
-    handler: dist/handlers/getMonthlyStatements.handler
+    handler: src/handlers/getMonthlyStatements.handler
     events:
       - http:
           path: statements/{accountId}/{year}/{month}
           method: get
+
+resources:
+  Resources:
+    TransactionEventListenerLambdaPermission:
+      Type: AWS::Lambda::Permission
+      Properties:
+        Action: lambda:InvokeFunction
+        FunctionName:
+          Fn::GetAtt:
+            - TransactionEventListenerLambdaFunction
+            - Arn
+        Principal: events.amazonaws.com
+        SourceArn:
+          Fn::GetAtt:
+            - TransactionEventListenerEventRule
+            - Arn
+
+    TransactionEventListenerEventRule:
+      Type: AWS::Events::Rule
+      Properties:
+        EventBusName: default
+        EventPattern:
+          source:
+            - 'accounts-service'
+          detail-type:
+            - 'TransactionCreated'
+        Targets:
+          - Arn:
+              Fn::GetAtt:
+                - TransactionEventListenerLambdaFunction
+                - Arn
+            Id: "TransactionEventListenerTarget"
 
 package:
   individually: true
@@ -53,7 +88,6 @@ build:
     target: "node20"
     platform: "node"
     exclude: 
-      # - "jest"
-      # - "mongodb-memory-server"
-      - "prettier"
-    buildConcurrency: 3
+      - "jest"
+      - "mongodb-memory-server"
+      - "prettier"

src/events/mockEventBridge.json

@@ -0,0 +1,18 @@
+{
+  "version": "0",
+  "id": "c0cfc740-a244-f569-5a34-e7784dc1f12c",
+  "detail-type": "TransactionCreated",
+  "source": "accounts-service",
+  "accountId": "123456789012",
+  "time": "2024-08-29T07:35:00Z",
+  "date": "2024-08-29T07:35:00Z",
+  "region": "eu-north-1",
+  "resources": [],
+  "detail": {
+    "accountId": "66cbccb349f8791ba0cc98b8",
+    "type": "INBOUND",
+    "currency": "USD",
+    "amount": 909,
+    "date": "2024-08-29T07:35:00Z"
+  }
+}

src/handlers/transactionEventListener.ts

@@ -1,23 +1,21 @@
 import { Statement } from '../models/statement'
 import { connectToDatabase } from '../utils/connectToDB'
-import { TransactionEvent } from '../events/transactionEvent'
 import { ReportingService } from '../services/reportingService'
 
 interface EventBridgeEvent {
   Records: {
-    body: string;
-  }[];
+    body: string
+  }
 }
 
 export const handler = async (event: EventBridgeEvent): Promise<void> => {
   await connectToDatabase()
   const reportingService = new ReportingService(Statement)
-  // Check if running locally by detecting if it's an API Gateway event or a direct invocation
-  const records = event.Records
-  console.log({ records });
-  for (const record of records) {
-    const transactionEvent: TransactionEvent = JSON.parse(record.body)
-
-    await reportingService.processTransactionEvent(transactionEvent)
+  const transactionEvent = JSON.stringify(event, null, 2)
+
+  try {
+    await reportingService.processTransactionEvent(JSON.parse(transactionEvent).detail)
+  } catch (e) {
+    console.error("Error in processing transaction", e)
   }
 }

src/services/reportingService.ts

@@ -15,7 +15,7 @@ export class ReportingService {
   async processTransactionEvent(event: TransactionEvent): Promise<void> {
     const { accountId, currency, amount, type, date } = event
     const { month, year } = getMonthYearFromDate(date)
-
+    
     let statement = await this.statementModel.findOne({ accountId, month, year }).exec()
     if (!statement) {
       statement = new this.statementModel({
@@ -25,7 +25,7 @@ export class ReportingService {
         currencies: [],
       })
     }
-
+    
     let currencyStatement = statement.currencies.find(
       (cs) => cs.currency === currency,
     )
@@ -38,7 +38,7 @@ export class ReportingService {
       }
       statement.currencies.push(currencyStatement)
     }
-
+    
     const currencyStatementIndex = statement.currencies.findIndex(
       (cs) => cs.currency === currency,
     )