Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: union ops #3872

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

universalmind303
Copy link
Contributor

adds the following to both dataframe and sql

  • union (distinct union)
  • union_all
  • union_by_name (distinct union by name)
  • union_all_by_name

closes #3855

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 89.13043% with 15 lines in your changes missing coverage. Please review.

Project coverage is 78.42%. Comparing base (cf8cc14) to head (dfac4b2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-logical-plan/src/ops/set_operations.rs 83.11% 13 Missing ⚠️
src/daft-connect/src/spark_analyzer.rs 85.71% 1 Missing ⚠️
src/daft-logical-plan/src/logical_plan.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3872      +/-   ##
==========================================
+ Coverage   78.34%   78.42%   +0.07%     
==========================================
  Files         763      763              
  Lines       96742    96831      +89     
==========================================
+ Hits        75796    75935     +139     
+ Misses      20946    20896      -50     
Files with missing lines Coverage Δ
daft/dataframe/dataframe.py 85.25% <100.00%> (+0.22%) ⬆️
daft/logical/builder.py 92.02% <100.00%> (+0.12%) ⬆️
src/daft-logical-plan/src/builder/mod.rs 88.79% <100.00%> (+0.90%) ⬆️
src/daft-sql/src/planner.rs 82.27% <100.00%> (+1.77%) ⬆️
src/daft-connect/src/spark_analyzer.rs 77.92% <85.71%> (+0.17%) ⬆️
src/daft-logical-plan/src/logical_plan.rs 74.36% <0.00%> (+0.21%) ⬆️
src/daft-logical-plan/src/ops/set_operations.rs 79.48% <83.11%> (+8.14%) ⬆️

... and 6 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "union by name"
2 participants