Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D HW in 3D #214

Closed
jwscook opened this issue Nov 1, 2023 · 12 comments · May be fixed by #220
Closed

3D HW in 3D #214

jwscook opened this issue Nov 1, 2023 · 12 comments · May be fixed by #220
Assignees
Labels

Comments

@jwscook
Copy link
Member

jwscook commented Nov 1, 2023

No description provided.

@jwscook
Copy link
Member Author

jwscook commented Nov 1, 2023

@oparry-ukaea oparry-ukaea mentioned this issue Dec 4, 2023
9 tasks
@jwscook
Copy link
Member Author

jwscook commented Dec 6, 2023

Implementation seems to work - #220

@jwscook
Copy link
Member Author

jwscook commented Jan 17, 2024

There is one remaining test that isn't quite right. Otherwise basically done.

@jwscook
Copy link
Member Author

jwscook commented Feb 7, 2024

@oparry-ukaea are you happy for me to close this down?

@oparry-ukaea
Copy link
Contributor

Not yet - still need to resolve the issue with the energy test.

@jwscook
Copy link
Member Author

jwscook commented Apr 10, 2024

Owen currently working on the energy tests (and implicit timestepping for 2D and 3D separate PRs)

@jwscook
Copy link
Member Author

jwscook commented Apr 17, 2024

2Din3D works. Will do 3D in 3D after NESO becomes a library.

@jwscook
Copy link
Member Author

jwscook commented Apr 24, 2024

This runs but there is still an issue with the energy conservation.

@jwscook
Copy link
Member Author

jwscook commented Nov 20, 2024

@oparry-ukaea can we close this?

@oparry-ukaea
Copy link
Contributor

Still haven't resolved the energy conservation discrepancy, but the branch is getting a long way behind - probably worth merging it and creating an issue to follow up later.

@jwscook
Copy link
Member Author

jwscook commented Nov 20, 2024

Let's merge the hw3d branch and open a branch to check conservation.

@jwscook
Copy link
Member Author

jwscook commented Nov 20, 2024

Closed in favour of #263

@jwscook jwscook closed this as completed Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants