-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3D HW in 3D #214
Comments
https://github.com/ExCALIBUR-NEPTUNE/nektar-driftplane/pull/2/files is how to do fluxes |
Implementation seems to work - #220 |
There is one remaining test that isn't quite right. Otherwise basically done. |
@oparry-ukaea are you happy for me to close this down? |
Not yet - still need to resolve the issue with the energy test. |
Owen currently working on the energy tests (and implicit timestepping for 2D and 3D separate PRs) |
2Din3D works. Will do 3D in 3D after NESO becomes a library. |
This runs but there is still an issue with the energy conservation. |
@oparry-ukaea can we close this? |
Still haven't resolved the energy conservation discrepancy, but the branch is getting a long way behind - probably worth merging it and creating an issue to follow up later. |
Let's merge the |
Closed in favour of #263 |
No description provided.
The text was updated successfully, but these errors were encountered: