Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D HW #220

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

3D HW #220

wants to merge 29 commits into from

Conversation

oparry-ukaea
Copy link
Contributor

@oparry-ukaea oparry-ukaea commented Dec 4, 2023

Description

Add 3D HW equation system to the H3LAPD solver.
Resolves #214

Type of change

  • New feature (non-breaking change which adds functionality)

Testing

HWTest.3DHWGrowthRates (in test/integration/solvers/H3LAPD/test_H3LAPD.cpp)

Runs the H3LAPD solver with the "HW3DSystem" equation system for a small number of steps with periodic BCs on all sides.
Particle number is set to 0.
Tests that growth rate of enstrophy matches analytical expected rate (see equation 9 in [this ref]).(https://pubs.aip.org/pop/article/6/6/2401/263757/Resistive-drift-wave-turbulence-in-a-three).
Passes iff rate matches to a tolerance of 5e-3 AND the solver returns 0.

N.B. Test of energy growth rate is turned off for now. (To be reviewed later).

Test Configuration:

OS: Ubuntu 22.04
Compiler: GCC 11.4.0 / OneAPI v2024.1.0
SYCL implementation: Hipsycl v0.9.4 / DPC++ v2024.1.0
MPI details: MPICH v4.0.2 / Intel MPI 2021.8 Build 20221129
Hardware: CPU (Intel Alder Lake)

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have used understandable variable names
  • I have run clang-format against my *.hpp and *.cpp changes
  • I have run cmake-format against my changes to CMakeLists.txt
    - [ ] I have made corresponding changes to the documentation
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@oparry-ukaea oparry-ukaea marked this pull request as ready for review December 9, 2024 12:47
@oparry-ukaea oparry-ukaea added the Awaiting Review PR waiting to be reviewed. label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Review PR waiting to be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3D HW in 3D
1 participant