Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use standard options for CMAKE_BUILD_TYPE #139

Open
cmacmackin opened this issue Jan 24, 2023 · 0 comments · May be fixed by #272
Open

Use standard options for CMAKE_BUILD_TYPE #139

cmacmackin opened this issue Jan 24, 2023 · 0 comments · May be fixed by #272
Labels
good first issue Good for newcomers

Comments

@cmacmackin
Copy link
Contributor

Our CMakeLists.txt file accepts CMAKE_BUILD_TYPE values of TEST, DEBUG, and RELEASE (all case-sensitive). However, the standard ones for CMake are Debug, Release, RelWithDebInfo and MinSizeRel. If we retain the TEST option (which would make sense, as that way we get coverage information) then it shouldn't be in all caps (i.e., it should be Test instead).
@cmacmackin cmacmackin added the good first issue Good for newcomers label Jan 24, 2023
@oparry-ukaea oparry-ukaea linked a pull request Dec 11, 2024 that will close this issue
Draft
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use standard options for CMAKE_BUILD_TYPE ExCALIBUR-NEPTUNE/NESO
1 participant
@cmacmackin