Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard options for CMAKE_BUILD_TYPE #272

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

oparry-ukaea
Copy link
Contributor

Description

Drops "DEBUG", "RELEASE" and "TEST" in favour of "Debug", "Release", "RelWithDebInfo", "MinSizeRel" and "Test".
Defines a NESO_DEBUG flag in Debug.

Fixes #139

Type of change

Please delete options that are not relevant.

  • Bug fix, sort of

Testing

No new tests

Test Configuration:

  • OS: Ubuntu 22.04
  • Compiler: GCC 11.4.0 / OneAPI v2024.1.0
  • SYCL implementation: Hipsycl v0.9.4 / DPC++ v2024.1.0
  • MPI details: MPICH v4.0.2 / Intel MPI 2021.8 Build 20221129
  • Hardware: CPU (Intel Alder Lake)

Checklist:

- [ ] I have added tests that prove my fix is effective or that my feature works

  • [] New and existing unit tests pass locally with my changes
  • Any new dependencies are automatically built for users via cmake
  • I have used understandable variable names
  • I have run clang-format against my *.hpp and *.cpp changes
  • I have run cmake-format against my changes to CMakeLists.txt
    - [ ] I have run black against changes to *.py
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use standard options for CMAKE_BUILD_TYPE
1 participant