Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/higher order mesh particle interface #265

Open
wants to merge 68 commits into
base: main
Choose a base branch
from

Conversation

will-saunders-ukaea
Copy link
Contributor

WIP

Description

Please include a summary of changes, motivation and context for this PR.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • API change (breaks downstream workflows and requires major semver bump)
  • Requires documentation updates

Testing

Please describe the tests that you ran to verify your changes and provide instructions for reproducibility. Please also list any relevant details for your test configuration.

  • Test Foo in /test/path/to/file_for_test_Foo.cpp
  • Description of test Foo
  • Test Bar in /test/path/to/file_for_test_Bar.cpp
  • Description of test Bar

Test Configuration:

  • OS:
  • SYCL implementation:
  • MPI details:
  • Hardware:

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any new dependencies are automatically built for users via cmake
  • I have used understandable variable names
  • I have run clang-format against my *.hpp and *.cpp changes
  • I have run cmake-format against my changes to CMakeLists.txt
  • I have run black against changes to *.py
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

######### DELETE THIS AND BELOW #########

How-to:

  1. Format C++ source code with clang-format
find ./src ./include ./test -iname \*.hpp -o -iname \*.cpp | xargs clang-format -i
  1. Format cmake files with cmake-format
cmake-format -i CMakeLists.txt src/nektar/CMakeLists.txt test/CMakeLists.txt
  1. Format python with black
find ./python -iname \*.py | xargs black

@will-saunders-ukaea will-saunders-ukaea added the work in progess Draft PR - not to merge! label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work in progess Draft PR - not to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant