Fixing RegTest for Terrain

[hgopalan]

Summary

Broke the previous PR trying to rebase. Clean RegTest

Pull request type

Please check the type of change introduced:

• [ X] Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

Checklist

The following is included:

• new unit-test(s)
• new regression test(s)
• documentation for new capability

This PR was tested by running:

• the unit tests
  • on GPU
  • on CPU
• the regression tests
  • on GPU
  • on CPU

Issue Number: #1289

[marchdf]

Here's what I am seeing:

• Looks like the terrain_box issue is fixed, except I am seeing:

Unused ParmParse Variables:
  [TOP]::DragForcing.verificationMode(nvals = 1)  :: [1]

Could you remove that line from test/test_files/terrain_box/terrain_box.inp ?

• nrel_terrain looks like it is using a restart:

Initializing I/O manager
Restarting from checkpoint ../nrel_precursor/chk02000
terminate called after throwing an instance of 'std::runtime_error'
  what():  Couldn't open file: ../nrel_precursor/chk02000/Header
SIGABRT
See Backtrace.0 file for details

Can you remove the restart line from that input file?

Thanks!!

[marchdf]

Minor edits requested, see my comment.

[hgopalan]

The regtests ran in less than a minute on 10 procs locally.

[marchdf]

Not quite there:

Restarting from checkpoint ../nrel_precursor/chk00010

WARNING: The following fields were missing in the restart file for one or more levels. Please check your restart file and inputs.
Missing checkpoint fields:
  - terrain_height
  - terrainz0

Grid summary:
  Level 0   30 grids  798720 cells  100 % of domain
            smallest grid: 16 x 28 x 32  biggest grid: 32 x 32 x 32

Shear Stress model: local
Heat Flux model: local
terminate called after throwing an instance of 'std::runtime_error'
  what():  Assertion `(m_in_times[0] <= time) && (time < m_in_times.back())' failed, file "/mnt/vdb/home/mhenryde/exawind/exawind-manager/environments/amr-wind-cpu-test/amr-wind/amr-wind/wind_energy/ABLBoundaryPlane.cpp", line 763
SIGABRT
terminate called after throwing an instance of 'std::runtime_error'
  what():  Assertion `(m_in_times[0] <= time) && (time < m_in_times.back())' failed, file "/mnt/vdb/home/mhenryde/exawind/exawind-manager/environments/amr-wind-cpu-test/amr-wind/amr-wind/wind_energy/ABLBoundaryPlane.cpp", line 763
SIGABRT
terminate called after throwing an instance of 'std::runtime_error'
  what():  Assertion `(m_in_times[0] <= time) && (time < m_in_times.back())' failed, file "/mnt/vdb/home/mhenryde/exawind/exawind-manager/environments/amr-wind-cpu-test/amr-wind/amr-wind/wind_energy/ABLBoundaryPlane.cpp", line 763
SIGABRT
terminate called after throwing an instance of 'std::runtime_error'
  what():  Assertion `(m_in_times[0] <= time) && (time < m_in_times.back())' failed, file "/mnt/vdb/home/mhenryde/exawind/exawind-manager/environments/amr-wind-cpu-test/amr-wind/amr-wind/wind_energy/ABLBoundaryPlane.cpp", line 763
SIGABRT
See Backtrace.1 file for details
See Backtrace.2 file for details
See Backtrace.3 file for details
See Backtrace.0 file for details

[marchdf]

Everything runs to completion now.