Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid OOB for hi boundary planes #1307

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Conversation

mbkuhn
Copy link
Contributor

@mbkuhn mbkuhn commented Oct 21, 2024

Summary

With the previous fix for hi boundary planes, I corrected the indices of the face velocities but did not account for the fact that the plane data being referenced is still at cell centers. This PR accounts for that, supplying the IntVect to shift the indices back to cell-centered if needed. Augmented unit test to make sure it works.

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

@mbkuhn mbkuhn requested review from marchdf and moprak-nrel October 21, 2024 22:45
@mbkuhn mbkuhn force-pushed the index_hi_bdy_face_to_cc branch from 7ea7f38 to e2a1504 Compare October 22, 2024 03:56
@mbkuhn mbkuhn merged commit e2a2412 into Exawind:main Oct 22, 2024
15 checks passed
@mbkuhn mbkuhn deleted the index_hi_bdy_face_to_cc branch October 22, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants