Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten solver tolerances for terrain reg test on GPU #1312

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Oct 23, 2024

Summary

To avoid reg test non-determinism when running on GPU, it's good to have tight tolerances for the linear solvers. Also fixed a bunch of whitespace weirdness.

GPU Run-to-run variability before this PR:

            variable name            absolute error            relative error
                                        (||A - B||)         (||A - B||/||A||)
 ----------------------------------------------------------------------------
 level = 0
 density                                          0                         0
 mu_turb                            1.199741639e-08           6.670257731e-10
 temperature                        2.304420832e-08           7.419106396e-11
 temperature_mueff                  3.599225096e-08           6.670256295e-10
 terrain_height                                   0                         0
 terrainz0                                        0                         0
 velocityx                          7.774811905e-10           7.154064139e-11
 velocityy                          1.340445602e-10           1.462027369e-10
 velocityz                          2.579388092e-10           4.365218156e-10
 velocity_mueff                     1.199741639e-08           6.670254023e-10
 terrain_blank                                    0                         0
 terrain_drag                                     0                         0

After:

            variable name            absolute error            relative error
                                        (||A - B||)         (||A - B||/||A||)
 ----------------------------------------------------------------------------
 level = 0
 density                                          0                         0
 mu_turb                            1.434971031e-10           7.978081558e-12
 temperature                         3.97903932e-13           1.281055768e-15
 temperature_mueff                  4.304914203e-10           7.978081503e-12
 terrain_height                                   0                         0
 terrainz0                                        0                         0
 velocityx                          2.060573934e-12           1.896056184e-13
 velocityy                          3.194278175e-12           3.484030062e-12
 velocityz                          2.683495787e-13           4.541426202e-13
 velocity_mueff                     1.434971031e-10           7.978077122e-12
 terrain_blank                                    0                         0
 terrain_drag                                     0                         0

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): reg test update

Checklist

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

@marchdf marchdf requested a review from jrood-nrel October 23, 2024 21:24
@marchdf marchdf enabled auto-merge (squash) October 23, 2024 21:31
@marchdf marchdf disabled auto-merge October 23, 2024 21:31
@marchdf marchdf enabled auto-merge (squash) October 23, 2024 21:31
@marchdf marchdf merged commit 517ff62 into Exawind:main Oct 23, 2024
15 checks passed
@marchdf marchdf deleted the fix-terrain-tols branch November 5, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants