-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate inflow-outflow BC into ABL #1321
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to run on the test machine. Otherwise looks good!
The only diff I see on CPU is |
Closes #1319 |
Yes, those are expected as I changed the test to involve flow along both x and y instead of just in x. |
Everything looked fine on GPU, not sure why docker is failing. I think it is irrelevant to this PR. |
Summary
These changes allow the use of the
mass_inflow_outflow
boundary condition with the ABL physics simulations that involve reading boundary planes. It also adds a new test to test this capability and updates the older inflow-outflow test to involve flow in both x- and y-directions. Finally, updating AMReX-Hydro solves a bug in the routines that enforce solvability by scaling the outflow to match the inflow.The new capability was verified by a qualitative comparison of the new
abl_bndry_input_native_inout
test with the olderabl_bndry_input_native
test which uses the simplemass_inflow
andpressure_outflow
BCs.Pull request type
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running: