Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate inflow-outflow BC into ABL #1321

Merged
merged 10 commits into from
Nov 1, 2024
Merged

Conversation

mukul1992
Copy link
Contributor

Summary

These changes allow the use of the mass_inflow_outflow boundary condition with the ABL physics simulations that involve reading boundary planes. It also adds a new test to test this capability and updates the older inflow-outflow test to involve flow in both x- and y-directions. Finally, updating AMReX-Hydro solves a bug in the routines that enforce solvability by scaling the outflow to match the inflow.

The new capability was verified by a qualitative comparison of the new abl_bndry_input_native_inout test with the older abl_bndry_input_native test which uses the simple mass_inflow and pressure_outflow BCs.

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU (Apple M3, macOS, gcc-13)
  • the regression tests
    • on GPU
    • on CPU (Apple M3, macOS, gcc-13)

@mukul1992 mukul1992 marked this pull request as ready for review October 31, 2024 19:19
@marchdf marchdf requested review from mbkuhn and marchdf October 31, 2024 19:35
Copy link
Contributor

@marchdf marchdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to run on the test machine. Otherwise looks good!

@marchdf
Copy link
Contributor

marchdf commented Oct 31, 2024

The only diff I see on CPU is freestream_godunov_inout. Running the GPU tests now.

@marchdf
Copy link
Contributor

marchdf commented Oct 31, 2024

Closes #1319

@mukul1992
Copy link
Contributor Author

The only diff I see on CPU is freestream_godunov_inout. Running the GPU tests now.

Yes, those are expected as I changed the test to involve flow along both x and y instead of just in x.

@marchdf
Copy link
Contributor

marchdf commented Nov 1, 2024

Everything looked fine on GPU, not sure why docker is failing. I think it is irrelevant to this PR.

@marchdf marchdf merged commit 32690a0 into Exawind:main Nov 1, 2024
14 of 15 checks passed
@mukul1992 mukul1992 deleted the mio_abl branch November 6, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants