Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terrain blanking #1355

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Update terrain blanking #1355

merged 2 commits into from
Nov 19, 2024

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Nov 18, 2024

Summary

Update terrain blanking so that the ghost cells are not tagged as blanked. This ensures only the actual part of the blanking gets tagged for refinement and not the whole bottom domain.

Tagging now looks like:
Screenshot 2024-11-18 at 4 06 30 PM

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

@marchdf marchdf marked this pull request as ready for review November 18, 2024 23:37
@marchdf marchdf enabled auto-merge (squash) November 18, 2024 23:37
@marchdf marchdf merged commit e7594fa into Exawind:main Nov 19, 2024
15 checks passed
@marchdf marchdf deleted the fix-terrain-blank branch December 3, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants