Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add abort when using a GPU backend with OpenMP #1359

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Add abort when using a GPU backend with OpenMP #1359

merged 2 commits into from
Nov 20, 2024

Conversation

jrood-nrel
Copy link
Contributor

No description provided.

@jrood-nrel jrood-nrel requested review from marchdf and mbkuhn November 20, 2024 00:22
@jrood-nrel jrood-nrel enabled auto-merge (squash) November 20, 2024 00:22
marchdf
marchdf approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@marchdf marchdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent idea. We have never tested this combination and I wouldn't trust it. We would need extensive tests to make sure that the results are valid before we allowed this combination.

@jrood-nrel jrood-nrel merged commit 3e9d3a8 into Exawind:main Nov 20, 2024
15 checks passed
@jrood-nrel jrood-nrel deleted the jrood/abort branch November 20, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchdf marchdf marchdf approved these changes

@mbkuhn mbkuhn Awaiting requested review from mbkuhn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrood-nrel @marchdf