Ocean Waves (Waves2AMR): correct conditional in treatment of ow_velocity #1372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This corrects a bug introduced in #1282. The conditional for this function within w2a is opposite of the other wave profiles because it zeros out the velocity where it doesn't apply, as opposed to only attributing the velocity where it does apply. Missed that the first time.
Should produce diffs in ow_w2a and abl_multiphase_w2a.
Pull request type
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running: