Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocean Waves (Waves2AMR): correct conditional in treatment of ow_velocity #1372

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

mbkuhn
Copy link
Contributor

@mbkuhn mbkuhn commented Nov 25, 2024

Summary

This corrects a bug introduced in #1282. The conditional for this function within w2a is opposite of the other wave profiles because it zeros out the velocity where it doesn't apply, as opposed to only attributing the velocity where it does apply. Missed that the first time.

Should produce diffs in ow_w2a and abl_multiphase_w2a.

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

@mbkuhn mbkuhn enabled auto-merge (squash) November 25, 2024 15:51
@mbkuhn mbkuhn merged commit 05e1bb1 into Exawind:main Nov 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants