-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ALM reg tests #1389
Add ALM reg tests #1389
Conversation
20d4a91
to
d6866b9
Compare
So far I have this. Red = T0, first run, green = T1, first run, blue = T0, restart run, orange = T1, restart run. They all do the same thing, which is expected. And blue and orange start later (since they are a restart) |
165d7fb
to
f906791
Compare
And with this restart case I can confirm the breakage I saw in #1385 and that breakage is not in 3.2.0. |
f906791
to
552deaa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @marchdf, this is great and something that has been sorely needed.
I'm adding in a note that the input files were generated with the notebook https://gist.github.com/lawrenceccheung/a775e8eb5162e906da2a75ce67169139, in case we want to generate other reg test type problems in the future.
Also, we should adopt a similar process of downloading the NREL5MW files from OpenFAST/r-test
for the benchmark problems. Or least, noting which commit they were downloaded from and documenting which changes to the openfast model were necessary for the benchmark problems to run. I know it's for a separate problem, but we should be handling them consistently (Tagging @ndevelder on this).
Lawrence
0521d7a
to
e2c5199
Compare
e2c5199
to
533fbc3
Compare
Summary
Add an ALM openfast reg tests. It's time. As much as we've been resisting this... It's critical enough and I recently broke something (#1385) that would have been caught if we had a reg test.
Pull request type
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running: