-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hand rolled interpolation #1393
Open
moprak-nrel
wants to merge
11
commits into
Exawind:main
Choose a base branch
from
moprak-nrel:mmc_bilinear_update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moprak-nrel
force-pushed
the
mmc_bilinear_update
branch
from
December 6, 2024 21:15
6d16266
to
e5cfd01
Compare
moprak-nrel
force-pushed
the
mmc_bilinear_update
branch
from
December 30, 2024 19:07
a2b0fae
to
fc3c8dd
Compare
Just waiting on the regtests now. I anticipate some small diffs, but want to ensure they look right. |
The only diffs in the regtests are
The first two are small/within expectations, but the tendency one has rather large diffs, looking into what I broke. |
Diffs are more reasonable now, only diffs are from a divide by zero for relative error, with |
moprak-nrel
force-pushed
the
mmc_bilinear_update
branch
from
January 3, 2025 22:29
f200cca
to
c0b8263
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace hand rolled interpolation with
interp::linear
andinterp::bilinear
as appropriate.Pull request type
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running:
Additional background
Issue Number: fixes #1364