Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for ALM restart #1400

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Fixes for ALM restart #1400

merged 3 commits into from
Dec 11, 2024

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Dec 10, 2024

Summary

Fixes for ALM restart:

  1. ensure the root proc is set right after regrid restart
  2. if restarting from a different directory, recreate the fast_velocity_data files

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

This basically recomputes the root_proc for the actuators if they are not valid. Which can happen on restart when post_regrid gets called. We have to do it this way because determine_influenced_procs needs a valid mesh at all levels (to make the intersections with the box array) and it needs (for turbine fast) a valid root proc. We can't just call determine_root_proc for the actuator (we need to call the plain utils version) because, as stated in a TODO comment in there, that function actually does much more, including initializing the openfast instance. Quite the cluster.

Closes #1385

@marchdf
Copy link
Contributor Author

marchdf commented Dec 10, 2024

Everything looks pretty good.
turbines.pdf

@marchdf marchdf marked this pull request as ready for review December 10, 2024 22:12
@marchdf marchdf merged commit 04b3fe8 into Exawind:main Dec 11, 2024
15 checks passed
@marchdf marchdf deleted the fix-alm-restart branch December 11, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion `info.root_proc > -1' failed
2 participants