Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fllc interface and docs improvements #1411

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

mbkuhn
Copy link
Contributor

@mbkuhn mbkuhn commented Dec 16, 2024

Summary

Make sure that the error message is clear and helpful for when faulty fllc_type is provided. Clarify what the default value is in the documentation and fix format there.

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

I checked the behavior of the new check using the act_fixed_wing_fllc regression test with different input lines.

Issue number: closes #1407

@mbkuhn
Copy link
Contributor Author

mbkuhn commented Dec 16, 2024

@rthedin

@mbkuhn mbkuhn merged commit 41f3962 into Exawind:main Dec 16, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FLLC type specification for ALM is not working
2 participants