Multiphase hybrid #915
Merged
Multiphase hybrid #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- sloppy commit
-- commenting or removing extra stuff
* also, found 1.5 * i_th works for pseudo-CFL
- corresponding version of levelset2vof
-huge bug fix for this method
* essential to better results with flat interface
-- should make this optional
- less noisy velocity field
- calculate pseudo dt based on pseudo CFL - make routine suited to multiple levels - remove unnecessary parts of disable_pressure_from_nalu
mbkuhn
added a commit
to mbkuhn/amr-wind
that referenced
this pull request
Oct 11, 2023
* option to sharpen nalu vof field or not * putting previous commit into practice * important options for sharpening and masking * able to turn off mac projection * getting toward a working sharpening -- sloppy commit * provides stability for very small epsilon (interface thickness) * removing unnecessary things, clean up * more unnecessary * default to a smaller interface thickness * masking fluxes is sufficient, no need to mask whole term * density fluxes and update (to make sure it works) * best upwinding approach so far * begin to look at the rest of the iteration * ability to turn off strong overset coupling to nodal projection * initialize pressure in sloshing tank case * modify pressure by hydrostatic source term -- commenting or removing extra stuff * momentum sharpening as included in paper * also, found 1.5 * i_th works for pseudo-CFL * to go with last change * ability to specify tolerance for convergence, not just steps * to go with previous commit * keep vof bounded * initialize pressure field for other cases (like waves) * specify relative length scale by input argument * move copy to old, misc * Neumann version of youngs normal - corresponding version of levelset2vof * discrete sharpening, much improved from other one * likely unused stuff, add for history * more reasonable asdf function, better for small nalu domains * more flexible flux computation and commented debugging stuff * populate ghost cells for iblank fields -huge bug fix for this method * making vof margin for flux upwinding/downwinding an input argument * changing defaults of sharpening tool * commented print statements for debugging * include boundedness of vof and recalc of density * new FuzzyInterface case * calculate face velocity in the upwinding/downwinding form like the vof fluxes * changing the sharpen margin default * essential to better results with flat interface * do density adjustment as intended * options to ignore nalu pressure and to turn off pressure source term in sharpening * cleaning up the code and putting in more options * replacing the pressure gradient with hydrostatic -- should make this optional * reapply hydrostatic guess of pressure gradient * turning latest commits into input options * switching to full upwinding for velocity sharpening * ramping the pseudo-time seems to work better - less noisy velocity field * ability to sharpen pressure gradient * 3 big changes - calculate pseudo dt based on pseudo CFL - make routine suited to multiple levels - remove unnecessary parts of disable_pressure_from_nalu * set current working version of options as default
mbkuhn
added a commit
to mbkuhn/amr-wind
that referenced
this pull request
Oct 11, 2023
* option to sharpen nalu vof field or not * putting previous commit into practice * important options for sharpening and masking * able to turn off mac projection * getting toward a working sharpening -- sloppy commit * provides stability for very small epsilon (interface thickness) * removing unnecessary things, clean up * more unnecessary * default to a smaller interface thickness * masking fluxes is sufficient, no need to mask whole term * density fluxes and update (to make sure it works) * best upwinding approach so far * begin to look at the rest of the iteration * ability to turn off strong overset coupling to nodal projection * initialize pressure in sloshing tank case * modify pressure by hydrostatic source term -- commenting or removing extra stuff * momentum sharpening as included in paper * also, found 1.5 * i_th works for pseudo-CFL * to go with last change * ability to specify tolerance for convergence, not just steps * to go with previous commit * keep vof bounded * initialize pressure field for other cases (like waves) * specify relative length scale by input argument * move copy to old, misc * Neumann version of youngs normal - corresponding version of levelset2vof * discrete sharpening, much improved from other one * likely unused stuff, add for history * more reasonable asdf function, better for small nalu domains * more flexible flux computation and commented debugging stuff * populate ghost cells for iblank fields -huge bug fix for this method * making vof margin for flux upwinding/downwinding an input argument * changing defaults of sharpening tool * commented print statements for debugging * include boundedness of vof and recalc of density * new FuzzyInterface case * calculate face velocity in the upwinding/downwinding form like the vof fluxes * changing the sharpen margin default * essential to better results with flat interface * do density adjustment as intended * options to ignore nalu pressure and to turn off pressure source term in sharpening * cleaning up the code and putting in more options * replacing the pressure gradient with hydrostatic -- should make this optional * reapply hydrostatic guess of pressure gradient * turning latest commits into input options * switching to full upwinding for velocity sharpening * ramping the pseudo-time seems to work better - less noisy velocity field * ability to sharpen pressure gradient * 3 big changes - calculate pseudo dt based on pseudo CFL - make routine suited to multiple levels - remove unnecessary parts of disable_pressure_from_nalu * set current working version of options as default
mbkuhn
added a commit
to mbkuhn/amr-wind
that referenced
this pull request
Oct 11, 2023
* option to sharpen nalu vof field or not * putting previous commit into practice * important options for sharpening and masking * able to turn off mac projection * getting toward a working sharpening -- sloppy commit * provides stability for very small epsilon (interface thickness) * removing unnecessary things, clean up * more unnecessary * default to a smaller interface thickness * masking fluxes is sufficient, no need to mask whole term * density fluxes and update (to make sure it works) * best upwinding approach so far * begin to look at the rest of the iteration * ability to turn off strong overset coupling to nodal projection * initialize pressure in sloshing tank case * modify pressure by hydrostatic source term -- commenting or removing extra stuff * momentum sharpening as included in paper * also, found 1.5 * i_th works for pseudo-CFL * to go with last change * ability to specify tolerance for convergence, not just steps * to go with previous commit * keep vof bounded * initialize pressure field for other cases (like waves) * specify relative length scale by input argument * move copy to old, misc * Neumann version of youngs normal - corresponding version of levelset2vof * discrete sharpening, much improved from other one * likely unused stuff, add for history * more reasonable asdf function, better for small nalu domains * more flexible flux computation and commented debugging stuff * populate ghost cells for iblank fields -huge bug fix for this method * making vof margin for flux upwinding/downwinding an input argument * changing defaults of sharpening tool * commented print statements for debugging * include boundedness of vof and recalc of density * new FuzzyInterface case * calculate face velocity in the upwinding/downwinding form like the vof fluxes * changing the sharpen margin default * essential to better results with flat interface * do density adjustment as intended * options to ignore nalu pressure and to turn off pressure source term in sharpening * cleaning up the code and putting in more options * replacing the pressure gradient with hydrostatic -- should make this optional * reapply hydrostatic guess of pressure gradient * turning latest commits into input options * switching to full upwinding for velocity sharpening * ramping the pseudo-time seems to work better - less noisy velocity field * ability to sharpen pressure gradient * 3 big changes - calculate pseudo dt based on pseudo CFL - make routine suited to multiple levels - remove unnecessary parts of disable_pressure_from_nalu * set current working version of options as default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lots of optional features, some will be removed in the future. Best working version is default.