Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Range query materialization #185

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Range query materialization #185

wants to merge 6 commits into from
+275 −64

Conversation

kpulipati29
Copy link

@kpulipati29 kpulipati29 commented Mar 4, 2025 •
edited
Loading

  1. Changes in online_write_batch to accommodate SortedFeaureView
  2. Changes in both batch and stream materialization process to pass the whole time series data (vs only the latest feature) in case of SortedFeaureView

piket
piket reviewed Mar 5, 2025
View reviewed changes
sdk/python/feast/infra/online_stores/contrib/cassandra_online_store/cassandra_online_store.py
@@ -74,6 +76,10 @@
" (?, ?, ?, ?) USING TTL {ttl};"
)

INSERT_TIME_SERIES_TEMPLATE = (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't call it "time series" since it can be used for any sorted set. I suggest going with "sorted features" to be consistent with the SortedFeatureView name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piket piket piket left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpulipati29 @piket