-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add PR check to verify examples #259
Conversation
06deaa9
to
5b518de
Compare
fb79f5f
to
5b518de
Compare
5b518de
to
1d6b8bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current checkstyle configuration is causing excessive line wrapping, particularly for logging statements and method calls, which reduces code readability.
Suggestion: Let's increase the line length limit to 180 characters and potentially add exceptions for logging statements. This would maintain code cleanliness while avoiding unnecessary verbosity.
Thoughts?
As discussed, we will stick with the default config |
f0290fc
Situation
Examples have no quality checks
Task
Verify that updates to examples do not break compilation or linting rules
Action
Add a GH action to verify examples whenever a PR updates them
Testing
Results
Examples are verified as part of PR checks
Notes