Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add PR check to verify examples #259

Merged
merged 4 commits into from
Feb 24, 2025
Merged

chore: add PR check to verify examples #259

merged 4 commits into from
Feb 24, 2025

Conversation

anssari1
Copy link
Contributor

@anssari1 anssari1 commented Dec 17, 2024

Situation

Examples have no quality checks

Task

Verify that updates to examples do not break compilation or linting rules

Action

Add a GH action to verify examples whenever a PR updates them

Testing

Screenshot 2024-12-17 at 4 16 25 PM

Results

Examples are verified as part of PR checks

Notes

@anssari1 anssari1 force-pushed the nanssari/pr_checks branch 2 times, most recently from 06deaa9 to 5b518de Compare December 17, 2024 13:03
@anssari1 anssari1 marked this pull request as ready for review December 17, 2024 13:09
@anssari1 anssari1 requested a review from a team as a code owner December 17, 2024 13:09
@anssari1 anssari1 changed the title chore: format examples chore: add PR check to verify examples Dec 17, 2024
Copy link
Member

@mohnoor94 mohnoor94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current checkstyle configuration is causing excessive line wrapping, particularly for logging statements and method calls, which reduces code readability.

Suggestion: Let's increase the line length limit to 180 characters and potentially add exceptions for logging statements. This would maintain code cleanliness while avoiding unnecessary verbosity.

Thoughts?

@anssari1
Copy link
Contributor Author

The current checkstyle configuration is causing excessive line wrapping, particularly for logging statements and method calls, which reduces code readability.

Suggestion: Let's increase the line length limit to 180 characters and potentially add exceptions for logging statements. This would maintain code cleanliness while avoiding unnecessary verbosity.

Thoughts?

As discussed, we will stick with the default config

dtayeh
dtayeh previously approved these changes Feb 18, 2025
@mohnoor94 mohnoor94 self-requested a review February 20, 2025 09:16
@anssari1 anssari1 dismissed stale reviews from Mohammad-Dwairi and dtayeh via f0290fc February 20, 2025 13:36
@anssari1 anssari1 merged commit 93e2769 into main Feb 24, 2025
3 checks passed
@anssari1 anssari1 deleted the nanssari/pr_checks branch February 24, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants