[iOS] add caretHeight and caretYoffset to TextInput component #37147 #58
Conversation
| @@ -38,6 +38,8 @@ void RCTCopyBackedTextInput( | |||
| toTextInput.keyboardAppearance = fromTextInput.keyboardAppearance; | |||
| toTextInput.spellCheckingType = fromTextInput.spellCheckingType; | |||
| toTextInput.caretHidden = fromTextInput.caretHidden; | |||
| toTextInput.caretYOffset = fromTextInput.caretYOffset; | |||
| toTextInput.caretHeight = toTextInput.caretHeight; | |||
There was a problem hiding this comment.
shouldn't be toTextInput.caretHeight = fromTextInput.caretHeight here?
OlimpiaZurek
force-pushed
the
feature/fix-caret-position
branch
from
0f17587
to
b85913b
Compare
|
Looking good so far, I'll test it out tomorrow. Sorry missing track of these, can anyone mention me here so I can pin the notifications to keep track of it. |
@Santhosh-Sellavel here's your ping |
|
Looks great! Simulator.Screen.Recording.-.iPhone.14.-.2023-05-31.at.00.52.53.mp4 |
|
Hmm, I have not seen that before. Looks like its normally skipped. Will ask around |
| @@ -368,6 +368,19 @@ type IOSProps = $ReadOnly<{| | |||
| * @platform ios | |||
| */ | |||
| smartInsertDelete?: ?boolean, | |||
| /** | |||
There was a problem hiding this comment.
NAB: Missing a blank line before this comment
| @@ -13,6 +13,41 @@ | |||
| #import <React/RCTBackedTextInputDelegateAdapter.h> | |||
| #import <React/RCTTextAttributes.h> | |||
|
|
|||
| //the UITextSelectionRect subclass needs to be created because the original version is not writable | |||
There was a problem hiding this comment.
NAB:
| //the UITextSelectionRect subclass needs to be created because the original version is not writable | |
| // the UITextSelectionRect subclass needs to be created because the original version is not writable |
|
Tested well, we can ignore the @OlimpiaZurek Can you update the base to be |
|
Please target |
|
@OlimpiaZurek bump! |
1 similar comment
|
@OlimpiaZurek bump! |
|
@alex-mechler Can you give a bump on any internal channels for callstack! |
|
Actually, we might not need to, based on. https://expensify.slack.com/archives/C01GTK53T8Q/p1686159512184629. We are moving towards deprecating our fork of RN |
|
FYI I have bumped the upstream PR with Meta |
|
@AndrewGable Can you bump again? |
|
@OlimpiaZurek - Can you fix the upstream PR's conflicts and then I can reach out again? Thanks. |
|
Or @koko57 since you might have access to the fork? Thanks |
Yes, I will take care of this tomorrow 😊 |
OlimpiaZurek
changed the base branch from
Expensify-0.71.2-alpha.3
to
ExpensifyRC1-0.72.0-alpha.0
|
@AndrewGable all conflicts are resolved in the upstream PR, the target branch is changed here for |
|
Thank you, bumped the upstream PR for a review via Discord! |
|
@AndrewGable Still no review. Can you bump them again, thanks! |
Upstream PR Link
facebook#37147
Summary
This PR adds support for the
caretHeightandcaretPositionproperties in iOS multi-line TextInput. Based on these values, we can calculate the caret position and height and adjust them in the appl so that the cursor does not overlap the previous line of text.Changelog
[IOS] [ADDED] - caretHeight and caretPosition for multiline TextInput component
Test Plan
Default caret:
default_caret.mov
Caret with
caretHeightandcaretYOffsetadjustment:adjusting_caret.mov