Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [issue-71] disable svgo minify id attr #120

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Conversation

DonghyukJacobJang
Copy link
Collaborator

What kind of change does this PR introduce? (check at least one)

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Code style update
  • Refactor (refactoring or adding test which isn't a fix or add a feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Did you test your solution?

  • I lightly tested it in one browser
  • I deeply tested it in several browsers
  • I wrote tests around it (unit tests, integration tests, E2E tests)

Problem Description

Solution Description

Side Effects, Risks, Impact

  • N/A

Aditional comments:

@DonghyukJacobJang DonghyukJacobJang merged commit 9729e12 into master Jun 25, 2021
@DonghyukJacobJang DonghyukJacobJang deleted the issue-71-svgo branch June 25, 2021 14:45
Copy link
Contributor

@namniak namniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call. this way storybook should be able to automatically use the same SVGO settings via babelrc.
@DonghyukJacobJang did you test that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Svgs that use clip-path() ids can't be used more than once.
3 participants