Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the design_t #103

Merged
merged 26 commits into from
Mar 10, 2025
Merged

Refactor the design_t #103

merged 26 commits into from
Mar 10, 2025

Conversation

timfelle
Copy link
Collaborator

@timfelle timfelle commented Feb 24, 2025

Major update to the design type.
This PR will improve the reuseability of the design type by hiding implementation details behind a generic API.

@timfelle timfelle enabled auto-merge February 24, 2025 08:12
@timfelle timfelle disabled auto-merge February 24, 2025 08:12
@timfelle timfelle marked this pull request as draft February 24, 2025 08:13
@timfelle timfelle changed the title Avoid built-in names and improve error handling during compilation Refactor the design_t Feb 24, 2025
@timfelle timfelle added the enhancement New feature or request label Feb 24, 2025
@timfelle timfelle marked this pull request as ready for review February 27, 2025 07:17
@timfelle timfelle enabled auto-merge February 27, 2025 07:40
Copy link
Collaborator

@gloopydoop gloopydoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pulled in and everything runs fine.
I only left a few comments

@timfelle timfelle added this pull request to the merge queue Mar 10, 2025
Merged via the queue into develop with commit 2d136e0 Mar 10, 2025
14 checks passed
@timfelle timfelle deleted the refactor/design branch March 10, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants