User statistics #1519
Open
User statistics #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfelle
reviewed
Dec 13, 2024
Comment on lines
+167
to
+178
| !!Switch around fields to get correct orders | ||
| !!Put average direction mean_vel in scalar45 | ||
| !do i = 1, this%map_2d%n_2d | ||
| ! u = output_2d%v%x(i) | ||
| ! v = output_2d%w%x(i) | ||
| ! w = output_2d%p%x(i) | ||
| ! p = output_2d%u%x(i) | ||
| ! output_2d%p%x(i) = p | ||
| ! output_2d%u%x(i) = u | ||
| ! output_2d%v%x(i) = v | ||
| ! output_2d%w%x(i) = w | ||
| !end do |
There was a problem hiding this comment.
Maybe a bit of cleanup is in order?
Suggested change
| !!Switch around fields to get correct orders | |
| !!Put average direction mean_vel in scalar45 | |
| !do i = 1, this%map_2d%n_2d | |
| ! u = output_2d%v%x(i) | |
| ! v = output_2d%w%x(i) | |
| ! w = output_2d%p%x(i) | |
| ! p = output_2d%u%x(i) | |
| ! output_2d%p%x(i) = p | |
| ! output_2d%u%x(i) = u | |
| ! output_2d%v%x(i) = v | |
| ! output_2d%w%x(i) = w | |
| !end do |
|
Don't forget the documentation :-). |
|
|
||
| end subroutine user_stats_free | ||
|
|
||
| !> Compute the vorticity field. |
There was a problem hiding this comment.
Suggested change
| !> Compute the vorticity field. | |
| !> Update the statistics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User defined statistics.
Picks a field from the field_registry and computes the temporal average. Going to look through for documentation and such, but most things are in place.
The ordering of the output fields is kind of all over the place. Maybe best if everything would be output into the scalars?
Finishes the CTR porting adventure, interpolation next.
Based on #1494