Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move filter base type under src/ and complete the documentation of filters #1670

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
Draft

Move filter base type under src/ and complete the documentation of filters #1670

wants to merge 11 commits into from

Conversation

Shiyu-Sandy-Du
Copy link
Collaborator

@Shiyu-Sandy-Du Shiyu-Sandy-Du commented Jan 21, 2025 •
edited
Loading

This PR should contain the following stuffs

  • Move all filter-related code to src/filter;
  • Add documentation for filter base type and its derived types;
  • Maybe we should change the name of filters.f90 into another name to avoid confusion?

Maybe @timfelle and @gloopydoop have some good ideas.

timfelle
timfelle reviewed Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@timfelle timfelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filters.f90 should probably be called mappings or possibly just added to the math library since they are just simple 1d functions.

Shiyu-Sandy-Du and others added 10 commits January 27, 2025 14:44
@Shiyu-Sandy-Du
draft the initial documentation
a8edd0b
@Shiyu-Sandy-Du
Leave the filter type specification to later stage other than json (c…
b805452 
…onsidering the filter might be as test filter or the actual filter)
@Shiyu-Sandy-Du
Merge pull request #1676 from Shiyu-Sandy-Du/doc/filter
91b3424 
Doc/filter
@Shiyu-Sandy-Du
add a fctry subroutine to initialize a general filter
2140c1c
@Shiyu-Sandy-Du
support of using json to initialize the transfer function of the elem…
11f9dcd 
…entwise_filter
@Shiyu-Sandy-Du
move the initialization of the elementwise_filter in dynamic smagorin…
4fa743d 
…sky to elementwise_filter.f90
@Shiyu-Sandy-Du
Move build_1d of the elementwise_filter to the constructor, and updat…
7d486d7 
…e the documentation
@Shiyu-Sandy-Du
make filter_factory public
abf0a74
@Shiyu-Sandy-Du
Update elementwise_filter.f90
5493898 
fix a typo
@Shiyu-Sandy-Du
Update elementwise_filter.f90
7437957 
fix another typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timfelle timfelle timfelle left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shiyu-Sandy-Du @timfelle