JSON subdictionary for setting initial conditions #1738
+51
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Harry, there is probably a problem with the hemi in reframe. You have to change the case file template there. |
|
So you are just changing where the config for blasius is, right? I think that is good, since it is no longer shared between the bcs and the ics. |
|
btw, regarding Blasius in general: Should one not just add a correct Blasius profile? I would never use any of these approximations for a serious simulation. |
Yes please do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a json sub-dictionary instead of hard coding
case.fluidandcase.scalarto allow more re-usability offlow_icandscalar_ic.NOTE
There is a change to how the Blasius parameters enters case file, so I hope this doesn't cause an inconvenience to people already using this BC.