Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add Option for Bitrate Mapping Where Nearest Value is Always Matched #283

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

Nfrederiksen
Copy link
Collaborator

PR, with a bump in hls-vodtolive to version 3.1.1 - now enables a new engineOption:
alwaysMapBandwidthByNearest: Will enable HLSVod to always map video profiles from prev and current vod by whichever is nearest. Without this option, HLSVod will map by index of there are the same amount of video profiles in prev and current vod.

PR also fixes a fatal infinite loop bug.

birme
birme previously approved these changes Aug 8, 2023
Copy link
Contributor

@birme birme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birme
Copy link
Contributor

birme commented Aug 8, 2023

Looks good but I don't see how you enable the option?

@birme birme dismissed their stale review August 8, 2023 12:44

Looks good but I don't see how you enable the option?

@Nfrederiksen
Copy link
Collaborator Author

Yes, that part is comming

@Nfrederiksen Nfrederiksen requested a review from birme August 8, 2023 12:53
Copy link
Contributor

@birme birme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@Nfrederiksen Nfrederiksen merged commit a735bbe into master Aug 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants