Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Wrong Audio M3U8 When Request Is Mid-Loading Next Vod #305

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

Nfrederiksen
Copy link
Collaborator

This PR resolves #304,

PR also includes some clean-up and optimization of the manifest serving functions. Many lines were reused in the different functions, and now there is one common function for them all (video/audio/subtitle).

@Nfrederiksen Nfrederiksen added the enhancement New feature or request label Nov 30, 2023
@Nfrederiksen Nfrederiksen marked this pull request as ready for review November 30, 2023 15:21
Copy link
Contributor

@birme birme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! And fix looks good with a reusable function instead of duplicating code.

@Nfrederiksen Nfrederiksen merged commit c8bb11d into master Nov 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audio Manifest Returns Wrong Manifest When Request Is During Vod Switch
2 participants