Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#56): update variable handling #61

Merged
merged 7 commits into from
Feb 22, 2024
Merged

Conversation

zapfire88
Copy link
Contributor

CSP can now handle snake case representation id.

@zapfire88 zapfire88 requested review from bwallberg and birme February 22, 2024 09:32
Copy link
Contributor

@bwallberg bwallberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the eslint disable LGTM!

@bwallberg bwallberg force-pushed the 56-update-variable-handling branch from 404509c to 6974dc4 Compare February 22, 2024 12:05
Copy link
Contributor

@birme birme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bwallberg bwallberg force-pushed the 56-update-variable-handling branch from f52066c to 404509c Compare February 22, 2024 12:12
@birme birme linked an issue Feb 22, 2024 that may be closed by this pull request
@bwallberg bwallberg force-pushed the 56-update-variable-handling branch from 404509c to dd46fb9 Compare February 22, 2024 12:13
@birme birme merged commit 2185e69 into main Feb 22, 2024
5 checks passed
@birme birme deleted the 56-update-variable-handling branch February 22, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$Time$ segments are not handled
3 participants