feat: support multiple bitrate values in stream proxy filter #67
Conversation
Updated the stream proxy filter to parse both individual bitrate values and arrays of bitrate values for filtering. - Modified the input type `br` in the filter function to accept: - `number`: Individual bitrate values. - `number[]`: Arrays of bitrate values. - `"*"`: A wildcard to match any bitrate. This enhancement allows more flexible filtering based on bitrate specifications.
src/manifests/utils/configs.ts
Outdated
| !config?.br || config?.br === '*' || config?.br === segmentBitrate | ||
| !config?.br || | ||
| config?.br === '*' || | ||
| config?.br.toString().includes(segmentBitrate.toString()) //Checks if .br contains bitrates that need to be filtered |
There was a problem hiding this comment.
This part doesn't look safe to me. At this point params is JSON parsed, so it should be either a number, the string "*" or an array of numbers. We already handled if it's "*", so what we need to handle is if it's a number or array of numbers.
I would do something like this: Array.isArray(config?.br) ? config.br : [config.br]. Then you know it's an array and can check .includes consistently. (Array.from(something) does this too, but it's not safe to use in this specific case because it works differently with numbers).
I would also break up the filter function a bit more. Since it grew in complexity I think it's better / more clear to add a scope ({}) and explicit returns now.
The way you're doing it now with string.includes will detect false positives, for example if you specify 500000 it will also match with 1500000 or 5000000
Instead of converting it, we now just check if it's an array and then uses .includes()
friday
deleted the
59-feature-request-option-to-submit-a-list-of-bitrates-to-corrupt-on-target-segment
branch
Updated the stream proxy filter to parse both individual bitrate values and arrays of bitrate values for filtering.
brin the filter function to accept:number: Individual bitrate values.number[]: Arrays of bitrate values."*": A wildcard to match any bitrate.This enhancement allows more flexible filtering based on bitrate specifications.
This is done by instead of checking it against a direct number value we check if the provided bitrates (whether they are in an array or as a singular number) includes the bitrate in the segmentBitrate and checks true or false if, or if not, that is the case.
Let me know if anything has to be fixed, added examples of a test situation in the README as well as restructuring the type there (even if I have not changed the actual type, since that did not need to be done to be able to input several bitrates).
Closes #59