Merge branch 'fix/extend-hls-interstitial-tag-insertion' of https://g…

…ithub.com/Eyevinn/hls-splice into fix/extend-hls-interstitial-tag-insertion
Eyevinn · Nov 27, 2024 · 6a1f709 · 6a1f709
2 parents 4a08df0 + d2b11a6
commit 6a1f709
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 22 deletions.
diff --git a/index.js b/index.js
@@ -481,6 +481,7 @@ class HLSSpliceVod {
   }
 
   _insertInterstitialAtExtraMedia(offset, id, uri, isAssetList, extraAttrs, startDate, playlists, opts) {
+
     let HAS_CUE_ATTR = false;
     if (opts && opts.cue) {
       const cueValue = _parseValidCueValues(opts.cue);
@@ -489,6 +490,7 @@ class HLSSpliceVod {
         HAS_CUE_ATTR = true;
       }
     }
+
     const groups = Object.keys(playlists);
     for (let i = 0; i < groups.length; i++) {
       const group = groups[i];
@@ -655,27 +657,9 @@ class HLSSpliceVod {
         }
       }
 
-      this._insertInterstitialAtExtraMedia(
-        offset,
-        id,
-        uri,
-        isAssetList,
-        extraAttrs,
-        startDate,
-        this.playlistsAudio,
-        opts
-      );
-
-      this._insertInterstitialAtExtraMedia(
-        offset,
-        id,
-        uri,
-        isAssetList,
-        extraAttrs,
-        startDate,
-        this.playlistsSubtitle,
-        opts
-      );
+      this._insertInterstitialAtExtraMedia(offset, id, uri, isAssetList, extraAttrs, startDate, this.playlistsAudio, opts);
+
+      this._insertInterstitialAtExtraMedia(offset, id, uri, isAssetList, extraAttrs, startDate, this.playlistsSubtitle, opts);
 
       resolve();
     });

diff --git a/spec/hls_splice_spec.js b/spec/hls_splice_spec.js
@@ -1682,7 +1682,6 @@ describe("HLSSpliceVod with Demuxed Audio Tracks,", () => {
       .then(() => {
         const m3u8 = mockVod.getMediaManifest(4497000);
         let lines = m3u8.split("\n");
-
         expect(lines[12]).toEqual(
           '#EXT-X-DATERANGE:ID="001",CLASS="com.apple.hls.interstitial",START-DATE="1970-01-01T00:00:18.001Z",X-ASSET-URI="http://mock.com/asseturi",X-SNAP="OUT"'
         );